search

RLBot / RLBotGUI

34 stars 25 forks source link

Address minor concerns with number of download threads for incremental patching #140

Closed L0laapk3 closed 3 years ago

L0laapk3 commented 3 years ago

I have some minor concerns with changes made to L0laapk3/RLBotGUI/multithreaded-downloads.

Mainly that the threads spawned by the pool only serve to initiate and collect the downloads, and it does not make sense to scale them with the number of cpu cores available. All the CPU intensive work is still done on the main thread. For the same reasons it also doesn't make much sense to limit the threshold number of patches before full redownload based on cpu cores available.

The numbers I chose are arbitrary, but I don't think it is a good idea to scale them off of cpu cores.

tarehart commented 3 years ago

Thanks! If you could bump the version number in setup.py that would be great