Closed Darxeal closed 3 years ago
looks good to me - waiting for the rlbot pr to be deployed.
Why is the search bar not always shown?
The UI of "Special bots/scripts" is still gonna be super confusing for new users. I wonder if we should add a small header to separate things. Sketch:
Why is the search bar not always shown?
To reduce UI clutter, I figured it's only needed when there's a lot of bots. I can put it in other tabs as well if you guys want, but to make it work with the script dependencies, there's some more work needed (it should probably hide/show entire rows)
The UI of "Special bots/scripts" is still gonna be super confusing for new users. I wonder if we should add a small header to separate things. Sketch:
I think that looks good, but it takes up a lot of space vertically. Another option is to separate the 3 things onto different tabs. I'm not sure what's the best option 🤷
Get we get the search bar for the Standard tab too? I do agree with what Darx said, but I also think that that tab has a lot of bots
Or maybe not? that might be a bit much in the ui... maybe just the all tab is fine... ak
I like the search bar. I think we should keep it.
it takes up a lot of space vertically
I am not too concerned about this if it makes it easier to understand.
maybe just put the search bar back to where it was before
Added search field to the tabs with a lot of bots - Bots for 1v1 and Bots with teamplay
Added headers as per East's suggestion
Can you also update the screenshot in readme? Or I could do that once this is deployed in another PR as I know I have a full RLBot install.
Is this viable? Warnings are okay imo, it is a feature after all
Sure, that doable
I can see that you hardcoded when the search bar is shown, which seems reasonable if the GUI only show RLBotPack bots. But then there's people like me with tons for bots because I have run multiple tournaments. I end up with many bots in multiple of the categories. I would like the search bar everywhere - or, as an compromise, whenever there is more than 10(?) bots in a category.
I end up with many bots in multiple of the categories
I would argue that most bots outside of the botpack won't have any tags, so you'll have to use the All category anyway. But I added the search field to all the tabs. The dependencies needed a special behavior - the row is hidden only if none of the bots/scripts pass the filter.
Sounds great.
Do not merge this until https://github.com/RLBot/RLBot/pull/557 has been deployed. BotPack PR coming soon.
Implements #155, seperates bots into categories using predefined tags.
The definition of the categories can be found in
rlbot_gui/gui/js/categories.js
.1v1
teamplay
goalie
hoops
dropshot
snow-day
rumble
spike-rush
heatseeker
memebot
tag are displayed on the top rowenables-something
paired withrequires-something
/supports-something
are displayed in a way, best explained with a picture: to explain some edge cases:More changes:
Codebase related changes:
Feel free to have feedback, for the categories, their names, tag names, UI, etc.