RLBot / RLBotGUI

34 stars 25 forks source link

More stable and responsive layout & some fixes #171

Closed Darxeal closed 3 years ago

Darxeal commented 3 years ago

When the bot pool gets too big, instead of overflowing the entire page, the bot pool scrolls. Implements #84 The same applies to team cards. Thanks to this, the entire page never scrolls (unless resized too small). This makes the GUI feel more like a native app and less like a webpage, in my opinion.

Also, the bot pool card grows to fill the remaining space, so the other cards are always on the bottom in the same position.

9adb21ca3726bf6276523d624b5822fb

There are also some other fixes and improvements (see commits)

tarehart commented 3 years ago

I like it! One disadvantage is that the "scripts" section is out of view until they scroll down, so it's less discoverable. Maybe they could get their own narrow column? That could be done by someone else / in a separate CR, but I want to get your thoughts on that.

NicEastvillage commented 3 years ago

Giving scripts their own tab would be another simple solution.

Darxeal commented 3 years ago

Thanks!

Giving scripts their own tab would be another simple solution.

They already have their own tab (Special bots/scripts), which contains all of the scripts. I'm not sure if another tab with only scripts is beneficial

One disadvantage is that the "scripts" section is out of view until they scroll down, so it's less discoverable. Maybe they could get their own narrow column?

I agree that it's less discoverable, but it's only in the All tab. I'm not sure if a narrow column would look good, because the little script cards are very "horizontal", some with long names (e.g. twitch chat interaction). But I can try it and see