search

RLBot / gui-installer

https://rlbot.org
3 stars 2 forks source link

pin gevent to < 22 #2

Closed SavageSnowgoose closed 1 year ago

SavageSnowgoose commented 1 year ago

Fixes an issue with greenlet 2, pinning gevent to < 22 also causes greenlet to pin to < 2.

Greenelt 2 causes issues if the C++ redistributable is not present on a client machine and will cause RLBotGUI to not run.

VirxEC commented 1 year ago

I don't think this will work. The right place is probably https://github.com/RLBot/RLBotGUI/blob/master/setup.py#L14

SavageSnowgoose commented 1 year ago

I agree that setup.py is where it should be, but see comment at https://github.com/RLBot/RLBotGUI/blob/master/setup.py#L11. The nsi, alternate and this installer all have these extra pip commands that seem to be in response to that comment in the setup.py.