RLPR / LabelReviews

Reproducible Label Reviews
https://rlpr.github.io
4 stars 0 forks source link

S19 - A Heuristic-Based Decision Tree for Connected Components Labeling of 3D Volumes #19

Closed prittt closed 2 years ago

prittt commented 3 years ago

General info

Reviewer feedback

Details Results

paulviville commented 3 years ago

Hello, I'm running into a bit of trouble trying to build the project. I am working on the following:

I've followed your instructions to configure CMake, and generated the project alright, but labeling3D_EDPT22.c and 26 will not compile. 19 compiles fine, but the other two just seem to get stuck, nothing happens and there are no errors. I tried over from scratch and the same thing happens. I've never encountered such a problem before, Might you know what is causing it?

I used make -j12 a couple hours ago and it's still running. No progress is shown in the terminal.

stal12 commented 3 years ago

The problem could be related to the large code size of EPDT algorithms. Our Linux system is a desktop computer with:

EPDT_22c is compiled in 10 minutes, while EPDT_26c needs 1 hour and a half; you can try to wait some more time.

prittt commented 3 years ago

@paulviville which version of GCC are you using?

If you don't manage to build the two algorithms in a reasonable timeframe, we can provide you with an object file for both EPDT22c and EPDT26c or a docker image with the same environmental setup you mentioned above and the whole framework already built.

paulviville commented 3 years ago

I left for several hours, it seems to be done. Sorry for the worry

prittt commented 3 years ago

Great! Thank you for your effort.

paulviville commented 3 years ago

I checked up all the results. Everything is perfectly in order. Interestingly, my results for 26c for table 2 are all lower. In your table you have a factor of ~1.7 between results oif 22c and 26c, in my tests it's closer to 1.1. My alloc & dealloc times for figure 6 graphs are also a fraction of yours, so I assume my work computer has better hardware than what you used. Could that be the cause of such a huge change for the results of table 2?

stal12 commented 3 years ago

It is possibile that your hardware is better than what we used, but we have to consider another key element: the operating system. Results in the paper have been obtained on Windows, which has a worse performing memory management system (Towards Reliable Experiments on the Performance of Connected Components Labeling Algorithms, Journal of Real-Time Image Processing).

paulviville commented 3 years ago

Hello again, The instructions you give here on how to reproduce the tables of your article are very straight forward and useful. Your git contains what seems to be a fairly comprehensive manual. For the purpose of ICPR, do you think you could add the instructions here somewhere on your git? A small Readme explicitly on the topic of reproducing the results of your article, or a small section in your main description?

Best regards

prittt commented 3 years ago

Yes, of course. I've just created a separated README inside the doc folder of the YACCLAB project: you can find it here. A link pointing to that page is available also in the main YACCLAB README.