bug with perform_with_chrome and finally

RLesur / crrri

A Chrome Remote Interface written in R

https://rlesur.github.io/crrri/

Other

157 stars 12 forks source link

Closed cderv closed 5 years ago

cderv commented 5 years ago

Trying to understand what is going on with finally and promise_map

This change is

cderv commented 5 years ago

test failing 😞 strange...

RLesur commented 5 years ago

The bug comes from promises::promise_map(). I have opened an issue: https://github.com/rstudio/promises/issues/47 I've also implemented a turnaround in perform_with_chrome() through https://github.com/RLesur/crrri/commit/cb30818572719b6d35232615613a9650600f1928

cderv commented 5 years ago

Thanks for the investigation ! We don't need this anymore