Current implementation is using a new argument in Chrome$new().
Another choice would be to detect if a --user-data-dir is passed in extra_args and deactivate the creation of new work dir by crrri. Would be oriented toward a more advanced usage.
If provided in user_data_dir, the folder won't be deleted by crrri at the end. A message warn the user (but is inside a promise so print in a weirdly timing)
@yonicd, using this PR will help to test with a custom user data dir.
@RLesur what do you think ? Should we test and improve some usage ?
I know it works well in headful mode, but not sure to check in headless mode as chrome://version url does not work in headless mode.
yonicd
commented
4 years ago
This will close #90
Current implementation is using a new argument in
Chrome$new().Another choice would be to detect if a
--user-data-diris passed inextra_argsand deactivate the creation of new work dir by crrri. Would be oriented toward a more advanced usage.If provided in
user_data_dir, the folder won't be deleted by crrri at the end. A message warn the user (but is inside a promise so print in a weirdly timing)@yonicd, using this PR will help to test with a custom user data dir.
@RLesur what do you think ? Should we test and improve some usage ?
I know it works well in headful mode, but not sure to check in headless mode as
chrome://versionurl does not work in headless mode.