search

RLovelett / sports_data_api

A Ruby interface to the Sports Data API. API supports NFL, MLB, NHL, and NBA.
http://developer.sportsdatallc.com/api_gallery
Other
26 stars 28 forks source link

Fix fetching team data on schedule API for the NBA #50

Closed mathieujobin closed 8 years ago

mathieujobin commented 8 years ago

CC: @djhalaninext @BlaneCordes @dyang12

RLovelett commented 8 years ago

I'm not near a computer right now. But why did the build fail?

mathieujobin commented 8 years ago

Ruby 1.9.3 and 2.1 had different issues with bundler and other packages. Seems unrelated with my changes.

Le mar. 15 déc. 2015 à 18:22, Ryan Lovelett notifications@github.com a écrit :

I'm not near a computer right now. But why did the build fail?

— Reply to this email directly or view it on GitHub https://github.com/RLovelett/sports_data_api/pull/50#issuecomment-164923491 .

RLovelett commented 8 years ago

Alright I'll take a look at it later tonight. Hopefully I'll merge it sometime tomorrow.

mathieujobin commented 8 years ago

looks like I got 3 working solutions....

failures for ruby 2.1 and 2.2 were temporary failures.. restarting the build worked.

for 1.9.3 we have three options

last one, I'm only touching the .travis.yml file, so it might be best

RLovelett commented 8 years ago

Thank you for looking into this. Since Ruby 1.9.3 support was dropped in February of this year I think it is time for me to sunset support for it as well. I'm fine with just removing the configuration from the Travis build.

RLovelett commented 8 years ago

Please change the version from 0.2.4 to 0.3.0. Since we are dropping support for a Ruby interpreter lets go up a minor revision.

mathieujobin commented 8 years ago

you can relaunch the build, it passed on my fork https://travis-ci.org/venuenext/sports_data_api

RLovelett commented 8 years ago

I made a branch where all I did was remove support for 1.9.3 and the builds are consistently failing. See.

I'm totally confused. Especially cause it builds on your fork and not on this repo.

RLovelett commented 8 years ago

... and now they pass on Travis. I give up.

mathieujobin commented 8 years ago

I rebased after your other merge

RLovelett commented 8 years ago

After all this I've realized #51 allowed me to restore Ruby 1.9.3. So I did that with #55. Therefore, I've switched the version back from 0.3.0 to 0.2.4 and pushed a new tag and revision to RubyGems.

Thank you for your contribution.