search

RLovelett / sports_data_api

A Ruby interface to the Sports Data API. API supports NFL, MLB, NHL, and NBA.
http://developer.sportsdatallc.com/api_gallery
Other
26 stars 28 forks source link

Fix test reporter #59

Closed trevorrjohn closed 7 years ago

trevorrjohn commented 7 years ago

code climate test reporter is deprecated.

This also removes the rvm specific files. I don't think these should be checked in.

trevorrjohn commented 7 years ago

So this is just failing on ruby version 2.5-dev. Not sure if we can fix this nor if we should fix this. My thought is to change the travis file to only look at released ruby versions.

The issue was a compatibility issue with FakeWeb, I updated the webmock gem and all is good now.

trevorrjohn commented 7 years ago

Hey so I went through and updated the appropriate gems. Also removed test support for 1.9.3 and 2.0.0, while they are passing they are no longer supported by the ruby team and I felt like they don't need to be supported here either. Let me know what you think. My plan now is to start implementing golf and would love to hear your thoughts about it.

RLovelett commented 7 years ago

@trevorrjohn I'm writing a lot less Ruby code these days (in that it is near zero). I'm not really able to keep up with this in the way I hoped in the past.

Are you interested in being added as a contributor?

trevorrjohn commented 7 years ago

Yes! Definitely interested, @nicolo and I are working on implementing golf at the moment so we would both love to be contributors.

On Sat, Jan 28, 2017, 09:00 Ryan Lovelett notifications@github.com wrote:

Merged #59 https://github.com/RLovelett/sports_data_api/pull/59.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RLovelett/sports_data_api/pull/59#event-940273660, or mute the thread https://github.com/notifications/unsubscribe-auth/AApILroa96ov-QW0rIKh6jnjwBC7F-j4ks5rW0ndgaJpZM4LuBB_ .

RLovelett commented 7 years ago

I added him as well.