search

RMC-14 / RMC-14

RMC-14 is an asymmetric PvP game inspired by CM13, Space Station 13, that runs on Robust Toolbox.
https://discord.gg/rouny
MIT License
105 stars 222 forks source link

New MP Whistle now mutes anyone in an area who can't give orders #2660

Closed Vermidia closed 2 months ago

Vermidia commented 3 months ago

About the PR

This new red whistle will now mute anyone (except the user) in an area (radius 5, same as it's whistle range) who cannot give orders and is a marine.

Why / Balance

Mutes emote spammers and chatting, allowing briefings to be a little more peaceful. Kinda tackles the problem in #2586 but not quite in the way requested.

The full suggestion also would've made it not effect MP but they currently don't have any unique components so it currently does effect them.

Technical details

Add new system ApplyStatusToAreaonActivationSystem which currently only activates when something is used inhand. Applies a status in an area. Has blacklist and whitelist functionality.

Media

https://github.com/RMC-14/RMC-14/assets/32827189/6b93c528-fe8b-4c19-bb00-5d05980d35f3

Breaking changes

Nah

Changelog

:cl:

skypatrol21 commented 3 months ago

I use the whistle a lot to get attention and give orders both as FTL and SL while in combat. I feel like this would just make the item useless in combat. I think spammers is an admin issue that should be addressed with a boink, especially since the server is suppose to be mrp. Muting marines in combat might prevent important conversations from happening while not in yet, I can already see a JTAC being muted by the whistle and delaying an airstrike or mortar barrage by precious seconds.

Vermidia commented 3 months ago

The main problem is there can be a few spammers and they can be hard to manage. I could make the range or duration much shorter, it's mostly supposed to be a quick attention grabber.

Edit: Also it was supposed to be only for the military police, but they don't seem to have a unique whistle rn.

Going to see if I can port one.

Vermidia commented 3 months ago

Ok, made a specific MP whistle that's red and does the muting effect. For now, all MP roles will start with one on their necks, but it should probably move into the vendor when that's done.

QuietlyWhisper commented 3 months ago

Smug wants to think about it, but this can also go well with policing skill for the mp which is not done yet!

Vermidia commented 3 months ago

I can add a skill check bit to the component if you want to go that route.

QuietlyWhisper commented 3 months ago

Oh actually you're probably right, the skill is there it's just not used for anything

Vermidia commented 3 months ago

Ok, added skill support to the component (not in the prettiest way tbh, UseInHandEvent isn't great) that'll only have the status effect go off if the user has 2> police skill.

QuietlyWhisper commented 3 months ago

Can you provide more examples of use case

skypatrol21 commented 3 months ago

As an MP whistle, this is actually a really cool idea mb for not understanding it at first.

Vermidia commented 3 months ago

Other than silencing people during briefing, it'd ideally probably be used to stop arguments or rioters for a brief amount of time, at least enough for the MP to try to get a word in. You wouldn't really use it when trying to arrest someone because you probably need them to speak their case.

QuietlyWhisper commented 3 months ago

Can you have this not affect MP? Use the policing skill for them perhaps?

QuietlyWhisper commented 3 months ago

I'm trying to test this but the effect doesn't appear to work

Vermidia commented 3 months ago

Yeah I broke it for a bit. Atm it works off a whitelist and blacklist. I can try to have a "skill blacklist" too.

Skarletto commented 2 months ago

I don't think emote spammers should be an MP issue Interesting item, but I don't think giving MPs an item that can essentially mute RP is a good idea. I of course don't believe emote spammers are RP, but that shouldn't be fixed by an ingame item. I don't see any reason to mute arguments if people are having them at all. Mutinies are rare, and usually those are dealt with using violence, not words (to an extent, and if there are words, they are definitely important)

QuietlyWhisper commented 2 months ago

Skarlet may be onto something but I think for mutinies we could implement the unused antagonist character skill

Vermidia commented 2 months ago

Yeah that's fair. I'll close this for now.