RMGDFT / rmgdft

RMG is an Open Source code for electronic structure calculations and modeling of materials and molecules. It is based on density functional theory and uses a real space basis and pseudopotentials.
GNU General Public License v2.0
46 stars 11 forks source link

warning: value computed is not used #65

Closed frobnitzem closed 3 years ago

frobnitzem commented 3 years ago

Compiling produced a warning message related to increment n_count: https://github.com/RMGDFT/rmgdft/blob/baec0e3d5d83a97796c532cae261666c8d115aa2/RMG/Common/fire.cpp#L136

src/rmgdft/RMG/Common/fire.cpp: In function ‘void fire(double, double, double, double, int, int)’: src/rmgdft/RMG/Common/fire.cpp:136:9: warning: value computed is not used [-Wunused-value] *n_count ++; ^~~ Apparently, some parentheses are needed so that the value is incremented.

elbriggs commented 3 years ago

Thanks. Just committed a fix.