search

RMHogervorst / badgecreatr

Quickly place relevant badges at the top of your readme, stop copy pasting, start on your project
http://rmhogervorst.nl/badgecreatr
61 stars 22 forks source link

Automatically detect versions of R and the package. #24

Closed privefl closed 7 years ago

privefl commented 7 years ago

I think a nice feature would be that if you change the required minimal version of R or the version of your package in your DESCRIPTION file, the badges would be changed as well only by knitting your README again.

I think I managed to do so: see for example this Rmd file.

codecov-io commented 7 years ago

Current coverage is 28.57% (diff: 42.10%)

Merging #24 into master will increase coverage by 2.36%

@@             master        #24   diff @@
==========================================
  Files             4          4          
  Lines           145        154     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             38         44     +6   
- Misses          107        110     +3   
  Partials          0          0

Powered by Codecov. Last update e197f5b...5f7b4aa

RMHogervorst commented 7 years ago

Thanks for your PR! I think it would work wonderfully. My only concern is that this call is now no longer in the package itself. So perhaps we should add some check in the tests or something. I'll be back in a day

privefl commented 7 years ago

I am note sure I understand what you mean by

this call is now no longer in the package itself.

The badges will be created as before with the main function of the package. The only difference is that it also adds one R chunk before each version badges. So, it should be seemless for users, I think.

RMHogervorst commented 7 years ago

You are correct.

Thaks so much! This is a nice feature!