make which exchange rate to use an option

RMI-PACTA / PACTA_analysis

Run the PACTA analysis on EQ & CB portfolios

Other

25 stars 70 forks source link

make which exchange rate to use an option #113

Open jacobvjk opened 3 years ago

jacobvjk commented 3 years ago

https://github.com/2DegreesInvesting/PACTA_analysis/blob/1bbdc26b725f1a577c3f43fcc3a90161da0cd6b9/0_portfolio_input_check_functions.R#L462

This function calculates the holdings' value_usd using the exchange_rate from the currencies.rda file, whereas it should probably use the exchange_rate_usd from the financial data file.

We need to clarify if we can simply change the variable in use or if they are set up for different use cases. This may require some input from AR.

jacobvjk commented 3 years ago

@Clare2D

Clare2D commented 3 years ago

Was this resolved Jacob? I know we discussed it

jacobvjk commented 3 years ago

We did discuss it and wanted to circle back to checking it a bit later. Which might be now?

Clare2D commented 3 years ago

Yep. Seems like a good time! I saw this is a PR @cjyetman is working on - so possibly we should coordinate this