search

RMI-PACTA / PACTA_analysis

Run the PACTA analysis on EQ & CB portfolios
Other
25 stars 70 forks source link

move fund analysis from reference repo here #15

Open 2diiKlaus opened 4 years ago

2diiKlaus commented 4 years ago

Is your feature request related to a problem? Please describe. Don't want to loose the work!

Describe the solution you'd like for now just copy the relevant files here: https://github.com/2DegreesInvesting/Reference/pull/57 they work with the output of the "new datastore branch" https://github.com/2DegreesInvesting/Reference/pull/59

It will need some cleaning/formating to fully fit to the tidyverse-style

Clare2D commented 4 years ago

@vintented An issue to centralise discussion on the funds work. I think this can be broken down into two tasks:

  1. create the 2019Q4 fund file that matches the one in the current infrastructure
  2. move the code you've written to look up the funds to the data_prep repository. There it can live and be used to look up funds whenever we need them. The functionality of this should also include writing the current timestamp funds data to the analysis_input_data folder relevant for the timestamp (even if the funds data isn't recreated for this purpose - but this will be the location where it is saved and accessed). Make sense? Lower priority on this one though.
2diiKlaus commented 4 years ago

I am actually talking about a different thing here, it is the after PACTA analysis Fund analysis and not the fund preparation. @Clare2D please open a separate issue for your tasks as otherwise it will get to confusing.

Just to clarify @vintented : i want to move the 3_FundAnalysis work we did for NKI, LITA, etc. to the new repository to ensure this work is not getting lost in the transition.

The fund data preparation should also be moved, but rather to the data_prep repo and not the PACTA_analysis repo. , as said above. This requires a separate issue in my opinion. If both of you are fine with keeping all 3 tasks in one issue, I am happy with it as well.

Clare2D commented 4 years ago

I believe there is still a partial outstanding task here. I'm going to add this to the PACTA project board

2diiKlaus commented 4 years ago

@vintented We need to merge the fun code into the new "master" (i.e. PACTA_analysis). Can you do that when prior to guiding @looreen through the fun code next week?

Clare2D commented 4 years ago

I think @jacobvjk or @jdhoffa could be bought in to help on this.