search

RMI-PACTA / PACTA_analysis

Run the PACTA analysis on EQ & CB portfolios
Other
25 stars 70 forks source link

integration test incorrectly modifies #189

Closed cjyetman closed 4 years ago

cjyetman commented 4 years ago

this chunk modifies my parameter_files/WebParameters_2dii.yml, which makes the integration test fail, and causes more problems with my clone

https://github.com/2DegreesInvesting/PACTA_analysis/blob/ef5e55aa5fc3d2a3ff21dd6d3bda2c72b5fee861/integration-test.Rmd#L201-L230

it changes my parameter_files/WebParameters_2dii.yml from:

default:
    paths:
        # Prefer "../PACTA_analysis/" -- not "./" nor "/path/to/PACTA_analysis"
        project_location_ext: ../PACTA_analysis/
        data_location_ext: ../pacta-data/2019Q4/
        template_location: ../create_interactive_report/
        stress_test_location: ../StressTestingModelDev/
    parameters:
        project_name: working_dir
        twodii_internal: FALSE
        new_data: FALSE

to

default:
    paths:
        # Prefer "../PACTA_analysis/" -- not "./" nor "/path/to/PACTA_analysis"
        project_location_ext: /Users/cj2dii/Documents/Git/PACTA_analysis"/
        data_location_ext: /Users/cj2dii/Documents/Git/pacta-data/2019Q4/
        template_location: /Users/cj2dii/Documents/Git/create_interactive_report/
        stress_test_location: /Users/cj2dii/Documents/Git/StressTestingModelDev/
    parameters:
        project_name: working_dir
        twodii_internal: FALSE
        new_data: FALSE
cjyetman commented 4 years ago

after 401868a78b125c5d902c5376c801dbc71c99c59d the stray " that cause the integration test failure is fixed, but it still modifies the paths to absolute, user specific paths that are not portable

cjyetman commented 4 years ago

I assume this will be fixed in #191