search

RMI-PACTA / PACTA_analysis

Run the PACTA analysis on EQ & CB portfolios
Other
25 stars 70 forks source link

Can BoE ST code be removed from PACTA_analysis repo #94

Closed jacobvjk closed 3 years ago

jacobvjk commented 4 years ago

It seems to me like it can. Unless @Clare2D has any objections, I would consider the BoE code and stress testing code that are currently in this repo dead code and remove it.

Original message:

If it's unclear, I suggest you open another issue to remember, and come back to it once we have more tests -- i.e. a safety net to know if removing this code would actually break anything useful.

_Originally posted by @maurolepore in https://github.com/2DegreesInvesting/PACTA_analysis/pull/87#issuecomment-700647901_

Also: @maurolepore @Clare2D these functions have little to do with what we currently run as the stress test. This must be a pretty old version, probably used in the BoE study and I would suggest I do not try to dive into this as we should use the new version from this Stress Testing repo anyway https://github.com/2DegreesInvesting/StressTestingModelDev

Clare2D commented 4 years ago

This can be removed. The only used part of this is in the webtool repo so no need to worry

jacobvjk commented 4 years ago

@Clare2D we are talking about which webtool repo here?

Clare2D commented 4 years ago

The original, not what you're working on!