search

RMI-PACTA / actions

Actions for GitHub workflows
4 stars 0 forks source link

Add CODEOWNERS file #36

Closed AlexAxthelm closed 6 months ago

AlexAxthelm commented 9 months ago

I'm thinking that the CODEOWNERS for this repo (who would be tagged on all PRs) should maybe be @RMI-PACTA/developers, but maybe we want to have that on README (which should be updated for all new workflows), but specify individuals for certain files (for example, any non-breaking changes to the docker-* workflows are probably of interest to a few of us, but not everyone)

jdhoffa commented 9 months ago

NB: If we do it on README, we should have a check that README is always updated when a new workflow file is found/ name is changed

jdhoffa commented 8 months ago

I tend to think now that just you @AlexAxthelm should maintain this? You will be submitting most PRs. And you can just request a review from whoever you think it would affect on any contentious PR.

but you seem to have most context here by a long shot.

AlexAxthelm commented 8 months ago

I'm thinking that's the right call for most of the files, but I think I'd like to keep @RMI-PACTA/r-developers on the R.yml file, and @RMI-PACTA/devops on the docker.yml file, and @RMI-PACTA/developers on the other "calling" workflows (general.yml, housekeeping, issue.yml, etc) Since those may change default behaviors if anyone is using the @main branch

AlexAxthelm commented 6 months ago

Closed in #73