search

RMI-PACTA / pacta-dashboard-svelte

This is a demonstrative project, showing what a PACTA dashboard in Svelte might look like.
https://rmi-pacta.github.io/pacta-dashboard-svelte/
0 stars 0 forks source link

style: run `prettier --write .` #26

Closed jdhoffa closed 3 months ago

jdhoffa commented 3 months ago

In this PR, I ran the command: prettier --write . to style all files in this repository Note: to run this, you will need to have prettier installed, e.g. with npm install -g prettier.

Relates to https://github.com/RMI-PACTA/pacta-dashboard-svelte/pull/25 and more specifically the lintr check failure: https://github.com/RMI-PACTA/pacta-dashboard-svelte/actions/runs/10317927965/job/28563217921?pr=25

AlexAxthelm commented 3 months ago

@jdhoffa will this create new commits when styling? We've generally avoided creating commits from our actions so far.

MonikaFu commented 3 months ago

@jdhoffa as far as I understand you run the command once which resulted in a number of styling changes and it's not an automatic action? If that is the case then this looks good to me. I will install prettier and make sure I run it when I add code to the codebase.

jdhoffa commented 3 months ago

@MonikaFu @AlexAxthelm Exactly, Monika is correct. I manually styled the files locally and committed the resulting changes. There is no action that does this automatically since I understand that the team is against machines changing their code behind their backs 😉