search

RMI-PACTA / pacta.data.validation

pacta.data.validation
https://rmi-pacta.github.io/pacta.data.validation/
Other
2 stars 0 forks source link

add "ICE Hydrogen_HDV" to valid technology names #68

Closed cjyetman closed 4 months ago

cjyetman commented 4 months ago
github-actions[bot] commented 4 months ago
Coverage Report |file|head|main|diff| | :-- | --: | --: | --: | |Overall|95%|95%|:arrow_up: 0.0054%| |R/assert_columns_exists.R|100%|100%|0%| |R/assert_regex.R|100%|100%|0%| |R/assert_subset.R| 92%| 92%|0%| |R/assert_valid_ai_company_id.R| 0%| 0%|0%| |R/assert_valid_asset_type.R|100%|100%|0%| |R/assert_valid_bics_sector_code.R| 0%| 0%|0%| |R/assert_valid_bics_subgroup_code.R| 0%| 0%|0%| |R/assert_valid_emissions_factor_unit.R|100%|100%|0%| |R/assert_valid_equity_market.R| 0%| 0%|0%| |R/assert_valid_factset_entity_id.R|100%|100%|0%| |R/assert_valid_factset_fund_id.R| 0%| 0%|0%| |R/assert_valid_factset_sym_id.R| 0%| 0%|0%| |R/assert_valid_indicator_for_sector.R|100%|100%|0%| |R/assert_valid_indicator.R|100%|100%|0%| |R/assert_valid_isin.R|100%|100%|0%| |R/assert_valid_iso2c.R|100%|100%|0%| |R/assert_valid_iso4217c.R|100%|100%|0%| |R/assert_valid_production_unit.R|100%|100%|0%| |R/assert_valid_scenario_geography.R| 0%| 0%|0%| |R/assert_valid_sector.R| 98%| 98%|0%| |R/assert_valid_sectors_with_assets.R|100%|100%|0%| |R/assert_valid_technology_for_sector.R|100%|100%|0%| |R/assert_valid_technology.R|100%|100%|0%| |R/assert_valid_units.R|100%|100%|0%| |R/assert_valid_value_range_for_sector_unit_scenario_prep.R|100%|100%|0%| |R/fake_abcd_flags_bonds.R|100%|100%|0%| |R/fake_abcd_flags_equity.R|100%|100%|0%| |R/fake_currencies.R|100%|100%|0%| |R/fake_financial_data.R|100%|100%|0%| |R/fake_intermediate_scenario_data.R|100%|100%|0%| |R/fake_masterdata_debt_datastore.R|100%|100%|0%| |R/fake_masterdata_ownership_datastore.R|100%|100%|0%| |R/is_valid_isin.R|100%|100%|0%| |R/matches_regex.R|100%|100%|0%| |R/set_collapse.R|100%|100%|0%| |R/simplify_if_one_col_df.R|100%|100%|0%| |R/validate_abcd_flags_bonds.R|100%|100%|0%| |R/validate_abcd_flags_equity.R|100%|100%|0%| |R/validate_currencies.R|100%|100%|0%| |R/validate_financial_data.R|100%|100%|0%| |R/validate_intermediate_scenario_output.R|100%|100%|0%| |R/validate_masterdata_debt_datastore.R|100%|100%|0%| |R/validate_masterdata_ownership_datastore.R|100%|100%|0%|
jacobvjk commented 4 months ago

also does this clarify which technology this is mapped to in the data preparation? this was the main issue we had last year for not being able to fully replicate banks data from PAMS. this tech type was implicitly mapped to fuel cell in one place

cjyetman commented 4 months ago

also does this clarify which technology this is mapped to in the data preparation? this was the main issue we had last year for not being able to fully replicate banks data from PAMS. this tech type was implicitly mapped to fuel cell in one place

As I understand it, currently we do not map this to anything during data.prep, it just gets passed through as-is, which I believe means it effectively gets ignored because we don't have anything downstream that specifically looks for it.