search

RMI-PACTA / pacta.executive.summary

Repo containing the code to generate charts in the PACTA COP executive summary document.
https://rmi-pacta.github.io/pacta.executive.summary/
Other
2 stars 2 forks source link

Remove real estate related code from executive summary #307

Closed MonikaFu closed 4 months ago

MonikaFu commented 4 months ago

Closes #295

This is a breaking change. I could also only remove it from the templates and leave it in render_executive_summary() function for backward compatibility. However this option builds up tech debt in my opinion.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.70%. Comparing base (425f496) to head (9daf762).

:exclamation: Current head 9daf762 differs from pull request most recent head f2520f9. Consider uploading reports for the commit f2520f9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #307 +/- ## ===================================== Coverage 9.69% 9.70% ===================================== Files 27 27 Lines 2187 2185 -2 ===================================== Hits 212 212 + Misses 1975 1973 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdhoffa commented 4 months ago

@cjyetman @MonikaFu just noting that this was merged to main with 5/8 checks failing.

Please look into that ASAP, it still seems like a documentation issue.

See #309