RMI-PACTA / pacta.executive.summary

Repo containing the code to generate charts in the PACTA COP executive summary document.
https://rmi-pacta.github.io/pacta.executive.summary/
Other
2 stars 2 forks source link

feat: immediately filter for relevant `scenario_source` #316

Closed jdhoffa closed 4 months ago

jdhoffa commented 4 months ago

Since the scenario_thresholds file now has multiple possible scenario_source's, it is important to quickly filter it for only the relevant source, otherwise strange bugs appear:

Screenshot 2024-05-09 at 06 41 53
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 9.69%. Comparing base (4385412) to head (1b30c12).

Files Patch % Lines
R/prep_alignment_table.R 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #316 +/- ## ===================================== Coverage 9.69% 9.69% ===================================== Files 27 27 Lines 2187 2187 ===================================== Hits 212 212 Misses 1975 1975 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdhoffa commented 4 months ago

Note: testing locally, this fixes the bug that was preventing the alignment table from rendering (ignore the #debug lines)

Screenshot 2024-05-09 at 07 00 22