search

RMI-PACTA / pacta.executive.summary

Repo containing the code to generate charts in the PACTA COP executive summary document.
https://rmi-pacta.github.io/pacta.executive.summary/
Other
2 stars 2 forks source link

Update scenario used #325

Closed MonikaFu closed 5 months ago

MonikaFu commented 5 months ago

Update the thresholds and default scenario to align with what will be used in Swiss COP 2024.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 9.69%. Comparing base (2d3f1ca) to head (7c67ff4).

Files Patch % Lines
R/prep_scores.R 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #325 +/- ## ===================================== Coverage 9.69% 9.69% ===================================== Files 27 27 Lines 2187 2187 ===================================== Hits 212 212 Misses 1975 1975 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AlexAxthelm commented 5 months ago

@MonikaFu It looks like the extdata directory is big for this package. Is that expected?

https://github.com/RMI-PACTA/pacta.executive.summary/actions/runs/9226981271/job/25387941392?pr=325#step:6:291

cjyetman commented 5 months ago

Looks like the documentation needs to be regenerated to avoid the Warning in R CMD check

jdhoffa commented 5 months ago

I hope it's ok @MonikaFu I took the liberty to rebuild the docs since you are on PTO. Checks should pass now

jdhoffa commented 5 months ago

I see that the codecob/patch action is failing, though I remember we decided somewhere else that this was an action we might want to deactivate. @cjyetman can you remind me how/ where you disabled that portion of the codecov action?

See #326

jdhoffa commented 5 months ago

@MonikaFu I think we will need to update this file as well, do you have any idea how to do this? https://github.com/RMI-PACTA/pacta.executive.summary/blob/main/data-raw/remaining_carbon_budgets.R

Edit: Antoine is currently working on this. Tracked by https://github.com/RMI-PACTA/pacta.executive.summary/issues/318

cjyetman commented 5 months ago

I see that the codecob/patch action is failing, though I remember we decided somewhere else that this was an action we might want to deactivate. @cjyetman can you remind me how/ where you disabled that portion of the codecov action?

See #326

e.g. https://github.com/RMI-PACTA/pacta.portfolio.import/pull/94

MonikaFu commented 5 months ago

@AlexAxthelm extdata contains all the Rmd templates and example images so yeah, to be expected I'd say. It is not ideal that the templates are part of this package probably. Going forward (if we are planning to generate executive summaries regularly) we should probably move them to a separate directory.

MonikaFu commented 5 months ago

Thanks @jdhoffa for taking care of the documentation! My bad. I will open a separate PR to remove the codecov action for now. In general since the PR is approved by @jdhoffa and @AlexAxthelm are we good to go to merge it now?

jdhoffa commented 5 months ago

Good to merge!