Closed Antoine-Lalechere closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 9.69%. Comparing base (
b61c49d
) to head (9740ede
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thanks @Antoine-Lalechere. Reviewing now. If you want to use a path to azure storage instead of your local path, I don't think that this is possible. We could add a location of the file in a comment maybe. @jdhoffa do you have any input here?
Yeah, I would just comment the line out, and add a comment pointing to the relevant file on azure I guess it's somewhere here: https://portal.azure.com/#view/Microsoft_Azure_FileStorage/FileShareMenuBlade/~/browse/storageAccountId/%2Fsubscriptions%2Ffeef729b-4584-44af-a0f9-4827075512f9%2FresourceGroups%2FRMI-SP-PACTA-PROD%2Fproviders%2FMicrosoft.Storage%2FstorageAccounts%2Fpactarawdata/path/scenario-sources/protocol/SMB
More specifically, here:
https://pactarawdata.file.core.windows.net/scenario-sources/weo_2023-20240222/WEO2023 extended data/WEO2023_Extended_Data.xlsx
The last link did not work for me @jdhoffa. Should it work in a browser? My experience with azure is that you can point to a directory but not a specific file. So you need to give a file location in the directory next to the link in the comment.
In general, I would prefer that this dataset is an external dataset created in workflow.prep.*
and passed to the relevant function as it will change with each COP and I don't think it makes much sense for it to be an internal dataset in this package. But given the time sensitivity I'd leave it as it is for now and add an issue for the next time we touch this repo (if we are going to be running more COP projects with executive summaries in the future).
Closes #318
The last link did not work for me @jdhoffa. Should it work in a browser? My experience with azure is that you can point to a directory but not a specific file. So you need to give a file location in the directory next to the link in the comment.
Hmm indeed, it doesn't work for me either that's odd... that is the URL i get as a result of "copy link", but anyway, the files are here:
https://portal.azure.com/#view/Microsoft_Azure_FileStorage/FileShareMenuBlade/~/browse/storageAccountId/%2Fsubscriptions%2Ffeef729b-4584-44af-a0f9-4827075512f9%2FresourceGroups%2FRMI-SP-PACTA-PROD%2Fproviders%2FMicrosoft.Storage%2FstorageAccounts%2Fpactarawdata/path/scenario-sources/protocol/SMB
and the specific file is: WEO2023_Extended_Data.xlsx
I suppose so long as those two pieces of information are tracked for posterity, we are good
@MonikaFu @Antoine-Lalechere I leave it to you two to decide exactly how you want to achieve that.
Agreed that for this project we shouldn't overthink where the data is stored, but probably in the long-term having it in workflow.*
would make sense.
@jdhoffa I requested a review from you since it was me who finished the PR in the end and I don't want to be reviewing my own code 🙃 FYI @Antoine-Lalechere
@jdhoffa @MonikaFu here are the lines of code to update the weighting for WEO2023 for the Aggregate Score.
Scenario raw data are stored on the following link in Azure but I don't know how to link Azure and GH, so the link used is on my machine for now - can you help me with it? https://portal.azure.com/#view/Microsoft_Azure_FileStorage/FileShareMenuBlade/~/browse/storageAccountId/%2Fsubscriptions%2Ffeef729b-4584-44af-a0f9-4827075512f9%2FresourceGroups%2FRMI-SP-PACTA-PROD%2Fproviders%2FMicrosoft.Storage%2FstorageAccounts%2Fpactarawdata/path/scenario-sources/protocol/SMB