Fix to align with new scenario

RMI-PACTA / pacta.executive.summary

Repo containing the code to generate charts in the PACTA COP executive summary document.

https://rmi-pacta.github.io/pacta.executive.summary/

Other

2 stars 2 forks source link

Fix to align with new scenario #331

Closed MonikaFu closed 3 months ago

MonikaFu commented 3 months ago

Fixes to make https://github.com/RMI-PACTA/workflow.transition.monitor/pull/315 work:

update scenario_thresholds (#330 didn't do it in all places)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.69%. Comparing base (63ad533) to head (acf50ff).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #331 +/- ## ===================================== Coverage 9.69% 9.69% ===================================== Files 27 27 Lines 2187 2187 ===================================== Hits 212 212 Misses 1975 1975 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdhoffa commented 3 months ago

OMG im such a goofy doober I didn't build the data/!! Note to self: would be good to have an action that tries to source every script in data-raw and check the diff against data

MonikaFu commented 3 months ago

@jdhoffa I propose to review and merge this now. It will not solve all issues in executive summary plots but should solve all but one (scores plot) which require some input from analysts so it might take longer than expected.

MonikaFu commented 3 months ago

Issue #332 captures the problem with the scores.