search

RMI-PACTA / pacta.executive.summary

Repo containing the code to generate charts in the PACTA COP executive summary document.
https://rmi-pacta.github.io/pacta.executive.summary/
Other
2 stars 2 forks source link

Feat/334 remove indices from score card dir #335

Closed AlexAxthelm closed 4 months ago

AlexAxthelm commented 4 months ago

Closees #334

Relates to https://github.com/RMI-PACTA/workflow.transition.monitor/pull/326

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@93f8072). Learn more about missing BASE report.

Files Patch % Lines
R/prep_data_executive_summary.R 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #335 +/- ## ====================================== Coverage ? 9.69% ====================================== Files ? 27 Lines ? 2187 Branches ? 0 ====================================== Hits ? 212 Misses ? 1975 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AlexAxthelm commented 4 months ago

@jacobvjk @MonikaFu The ES seems to build clean with no "bonus" indices. See the renders: https://github.com/RMI-PACTA/workflow.transition.monitor/pull/326#issuecomment-2175690731

AlexAxthelm commented 4 months ago

LGTM. I assume this will follow a PR in templates.transition.monitor where we change the directory pointing to the indices?

Yep 326 in that repo.