RMI-PACTA / pacta.executive.summary

Repo containing the code to generate charts in the PACTA COP executive summary document.
https://rmi-pacta.github.io/pacta.executive.summary/
Other
2 stars 2 forks source link

add HydroCap in Renewables Energy Exposure #347

Closed Antoine-Lalechere closed 2 months ago

Antoine-Lalechere commented 2 months ago

@MonikaFu @NAYRA-HERRERA

In this document, https://rockmtnins.sharepoint.com/:w:/r/sites/PACTA/_layouts/15/Doc.aspx?sourcedoc=%7B712A81B4-872F-49F4-A1FF-D95C3C7E55D6%7D&file=04.%20ES%20-%20Swiss%20Climate%20Scorecard.docx&nav=eyJjIjozODg1NjQzNTR9&action=default&mobileredirect=true

Silvia provided some of the hard requirement now in place for the Swiss Score Card. We'll explain why we can't make most of them given timeline but this one appear quicker to go with than not to go with

We basically want hydro capacity to be added in Renewables Energy Exposure in the score Card

MonikaFu: testing here: https://github.com/RMI-PACTA/workflow.transition.monitor/pull/345

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 9.55%. Comparing base (0db5c8a) to head (3a53848).

Files Patch % Lines
R/plot_exposures_scorecard.R 12.50% 7 Missing :warning:
R/prep_exposures_scorecard.R 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #347 +/- ## ======================================== - Coverage 9.57% 9.55% -0.03% ======================================== Files 27 27 Lines 2213 2219 +6 ======================================== Hits 212 212 - Misses 2001 2007 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MonikaFu commented 2 months ago

Thanks @Antoine-Lalechere. Can you have a look into the text of the scorecard to make sure that we don't say anywhere that renewables is excluding hydro? Also - should we also change the plot in the PACTA analysis part of executive summary showing exposures? Otherwise the renewables exposures will be different in the scorecard from those in the main body of executive summary which I imagine might be confusing. What do you think @NAYRA-HERRERA ?

Antoine-Lalechere commented 2 months ago

For the text review, can you point me to where the text are stored and I can give a look

Good flag for the second chart, I think you are right but I let Nayra decide here.

MonikaFu commented 2 months ago

The text of the scorecard is here: https://github.com/RMI-PACTA/pacta.executive.summary/blob/main/inst/extdata/PA2024CH_en_exec_summary/scorecard.Rmd

NAYRA-HERRERA commented 2 months ago

Hi @MonikaFu I will update the text and share a document with you with the updates early next week. Will try to make it by Tuesday if that's ok for you. :) @Antoine-Lalechere fyi

MonikaFu commented 2 months ago

Since I added updates to code I need someone else to review @jdhoffa, that's why I added you.

jdhoffa commented 2 months ago

I'm confused, is this ready for review, or is it draft?

MonikaFu commented 2 months ago

@jdhoffa sorry, it is ready for review now. I turned it into draft until the test run on workflow.transition.monitor finishes.