search

RMI-PACTA / pacta.executive.summary

Repo containing the code to generate charts in the PACTA COP executive summary document.
https://rmi-pacta.github.io/pacta.executive.summary/
Other
2 stars 2 forks source link

Update index name change #389

Closed jdhoffa closed 5 days ago

jdhoffa commented 5 days ago

"MSCI World" -> "MSCI - WORLD"

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 9.55%. Comparing base (e744cb4) to head (8f24ded). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/prep_data_executive_summary.R 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #389 +/- ## ===================================== Coverage 9.55% 9.55% ===================================== Files 27 27 Lines 2219 2219 ===================================== Hits 212 212 Misses 2007 2007 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdhoffa commented 5 days ago

CI Build test can be found here: https://github.com/RMI-PACTA/workflow.transition.monitor/pull/385

MonikaFu commented 5 days ago

@jdhoffa if it is not too much work, can we add a check if expected index name is in the input data?

jdhoffa commented 5 days ago

@jdhoffa if it is not too much work, can we add a check if expected index name is in the input data?

I would prefer to merge this bug-fix as-is (just to get it in ASAP after the CI build is successful), and any nice-to-haves can be a separate PR. If that's ok :-)