search

RMI-PACTA / pacta.multi.loanbook.plot

Tools to Plot Climate Metrics for Multiple Loanbooks
https://rmi-pacta.github.io/pacta.multi.loanbook.plot/
Other
0 stars 0 forks source link

utils inside package #16

Closed jacobvjk closed 6 months ago

jacobvjk commented 6 months ago

closes #12

Note:

jacobvjk commented 6 months ago

FAILING CHECKS:

cjyetman commented 6 months ago
  • also if anyone has an idea what the message on R 3.6 with windows means, I would appreciate the clarification

looks like this is a known issue https://github.com/igraph/rigraph/blob/3811bfee687f19ef8213c651d45c3efbfe2e8d13/.github/workflows/check/action.yml#L12

cjyetman commented 6 months ago
  • not sure about the failing docs-check. Running document locally does not generate anything to commit.

caused by Roxygen being set to 7.2.3 currently in DESCRIPTION

Setting RoxygenNote to "7.3.1"

https://github.com/RMI-PACTA/pacta.multi.loanbook.plot/blob/f81789e7b394b11d19b2cbcd8ab4e2fad9bd7793/DESCRIPTION#L30

AlexAxthelm commented 6 months ago

It looks like the windows issue is because installing the igraph package is failing. https://github.com/RMI-PACTA/pacta.multi.loanbook.plot/actions/runs/8263622066/job/22605460577?pr=16#step:5:3471

jacobvjk commented 6 months ago

It looks like the windows issue is because installing the igraph package is failing. https://github.com/RMI-PACTA/pacta.multi.loanbook.plot/actions/runs/8263622066/job/22605460577?pr=16#step:5:3471

okay, given this hapens only in the R-CMD check workflow in this repository and not the one triggered rom the central actions repo, I wonder if I should just remove the ones from this repo and rely on the RMI/-PACTA/actions @AlexAxthelm ? It seems like a duplication of R CMD checks in any case

AlexAxthelm commented 6 months ago

I'll make a patch in the actions repo that lets you specify the matrix for testing R CMD CHECK.

in the meantime, it looks like igraph is only installed because of networkD3, and that's only called here:

https://github.com/RMI-PACTA/pacta.multi.loanbook.plot/blob/d02b1f6f2f76b4cff8983d9513c9685194917260/R/plot_sankey.R#L112

AlexAxthelm commented 6 months ago

from the igraph docs:

Do not compile igraph from sources, unless you know what you are doing! It is much more convenient to use the binaries from CRAN instead. These can be installed using install.packages("igraph").

...

CRAN provides Windows and macOS binaries only for the last two minor releases of R (e.g. 4.3 and 4.2), but not for older ones (e.g. 4.1). Make sure that you are using one of these supported R versions. Refer to https://r-project.org/ to find out what the latest R version is at the moment.

So it looks like the best option is to use the prebuilt binaries, which are not available for R 3.6

jacobvjk commented 6 months ago

your suggested fix will help with the actions from the RMI-PACTA/actions repo, but not with the standard R-CMD checks that are failing here @AlexAxthelm. I take that the immediate solution is therefore to rely on the central actions and remove the local ones?

jacobvjk commented 6 months ago

@AlexAxthelm the version check seems to expect a version bump. Is that desired?

AlexAxthelm commented 6 months ago

@AlexAxthelm the version check seems to expect a version bump. Is that desired?

@jacobvjk I think it's generally a good idea to bump versions as you update main, so you have something other than a git hash to distinguish between different versions.

if you want to disable that check, you can set do-compare-versions: false in the R.yml workflow file

AlexAxthelm commented 6 months ago

@jacobvjk See also #19, which brings back most of the R CMD checks that were here