RMI-PACTA / pacta.multi.loanbook

Calculate PACTA climate metrics across multiple loan books.
https://rmi-pacta.github.io/pacta.multi.loanbook/
Other
0 stars 0 forks source link

feat: maybe force `start_year` to be the start year of the scenario(s) used #220

Open jdhoffa opened 4 days ago

jdhoffa commented 4 days ago

Would the analysis even work (methodologically) if a different start_year was chosen? If not, we should probably just force that they use the correct one, rather than give an option that could be set incorrectly.

https://github.com/RMI-PACTA/pacta.multi.loanbook/blob/c0bc24e76f7f7b72d4c3e0bf9458011f0d4f4aa1/example.config.yml#L17-L19

jacobvjk commented 4 days ago

I was wondering about that in the past.. I think one issue with this used to be that the emission intensity pathways did not always have the implied start year as the first year in the data set. this seems to have been fixed though, since the scenario data prep has been overhauled. I think ideally the code would

If all these conditions are met, the start year can be set automatically. If not, the user should probably fix the input data. What do you think? We could also fix the forward looking timeframe at 5, if we want to.

jdhoffa commented 1 day ago

Hmm, actually now that we discuss it, I wonder if having data-inferred parameters is a bit brittle (for exactly the case you mention, what if the scenario data is misformatted for some reason).

I think one middle ground approach could be to:

Because it's true, for TMS we very much expect start_year == min(year), but for EI it is not really "required"