search

RMI-PACTA / pacta.multi.loanbook

Calculate PACTA climate metrics across multiple loan books.
https://rmi-pacta.github.io/pacta.multi.loanbook/
Other
0 stars 0 forks source link

split cook book in sections for each chapter #255

Closed jacobvjk closed 5 days ago

jacobvjk commented 6 days ago

closes #246

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.07%. Comparing base (b388a63) to head (a77b101). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ======================================= Coverage 52.07% 52.07% ======================================= Files 28 28 Lines 3161 3161 ======================================= Hits 1646 1646 Misses 1515 1515 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

jacobvjk commented 5 days ago

it seems like the file size of the vignettes does not go down well with the R-CMD check and triggers a note. @cjyetman @jdhoffa what do you think about making the cook book a set of articles instead of vignettes?

https://r-pkgs.org/vignettes.html#sec-vignettes-article

cjyetman commented 5 days ago

I'm not opposed to that.

jacobvjk commented 5 days ago

I am not sure the figures render.. locally I seem to struggle with that.. but I can't see why they shouldn't

Missing images in 'vignettes/cookbook_running_the_analysis.Rmd': '../reference/figures/p4s_workflow_structure.png' ℹ pkgdown can only use images in 'man/figures' and 'vignettes'

jdhoffa commented 5 days ago

it seems like the file size of the vignettes does not go down well with the R-CMD check and triggers a note. @cjyetman @jdhoffa what do you think about making the cook book a set of articles instead of vignettes?

https://r-pkgs.org/vignettes.html#sec-vignettes-article

Indeed, I think this is actually preferable/ what is recommended by pkgdown etc. Shall we tackle that in a separate issue/ PR?

jacobvjk commented 5 days ago

it seems like the file size of the vignettes does not go down well with the R-CMD check and triggers a note. @cjyetman @jdhoffa what do you think about making the cook book a set of articles instead of vignettes? https://r-pkgs.org/vignettes.html#sec-vignettes-article

Indeed, I think this is actually preferable/ what is recommended by pkgdown etc.

I refrained from that for the time being, because rendering the articles errored out. pkgdown did not manage to find the figures and I am unsure why