search

RMI-PACTA / pacta.pkgdown.rmitemplate

https://rmi-pacta.github.io/pacta.pkgdown.rmitemplate/
Other
2 stars 0 forks source link

Consider changing name of this repo #15

Closed jdhoffa closed 6 months ago

jdhoffa commented 7 months ago

Directories that end with .template are interpreted as a file extension on Mac, with the Pages template file type.

This is a bit of a pain, and may be worth nipping in the bud.

AlexAxthelm commented 7 months ago

pacta.template.pkgdown?

cjyetman commented 7 months ago

Originally I modeled this after https://github.com/tidyverse/tidytemplate/ and https://github.com/ropensci-org/rotemplate. Either I added the "." to stick with our pacta repos naming scheme, or they changed those names later. I think pacta.pkgdowntemplate might be logical?

jdhoffa commented 7 months ago

Since this repo is actively used in workflows to generate several pkgdown websites, may I suggest the following next steps:

I think all the relevant people are already on this thread, do you both agree with that strategy?

cjyetman commented 7 months ago

I think you can just rename this repo and then open the PRs in the other repos to point to the new name, no?

jdhoffa commented 7 months ago

Either works.

cjyetman commented 7 months ago

ah, now I get why you suggested that... up to you

AlexAxthelm commented 7 months ago

I vote for rename. Unless we open a new repo with the old name, everything should work as normal:

In addition to redirecting web traffic, all git clone, git fetch, or git push operations targeting the previous location will continue to function as if made on the new location. However, to reduce confusion, we strongly recommend updating any existing local clones to point to the new repository URL. You can do this by using git remote on the command line:

https://docs.github.com/en/repositories/creating-and-managing-repositories/renaming-a-repository

jdhoffa commented 6 months ago

I followed the tidytemplate style for the repository name.

I will leave this issue open for now until all repositories that use this workflow have updated their pkgdown workflows.

jdhoffa commented 6 months ago

AFAIK @cjyetman and myself are the only ones that make use of this pkgdown template but just in case: FYI @RMI-PACTA/developers

AlexAxthelm commented 6 months ago

See current status of migrating to new name: https://github.com/search?q=org%3ARMI-PACTA%20rmi-pacta%2Fpacta.pkgdown.template&type=code

cjyetman commented 6 months ago

hmmmm.... I thought we would also have to update our DESCRIPTION files, but I'm getting errors on my PRs

Caused by error: ! Could not solve package dependencies:

  • deps::.: Can't install dependency rmi-pacta/pacta.pkgdown.rmitemplate
  • local::.: Can't install dependency rmi-pacta/pacta.pkgdown.rmitemplate
jdhoffa commented 6 months ago

I'll look into it. Guess this morning is a pkgdown morning :D

cjyetman commented 6 months ago

maybe GitHub just needs some time to properly propagate the new name

jdhoffa commented 6 months ago

Yeah let's give it a little bit, and if we're still having trouble this afternoon we can look into it?

Off the top of my head, I'm not sure what else would have to change.

cjyetman commented 6 months ago

"break now, fix later" 🤣

jdhoffa commented 6 months ago

"break now, fix later" 🤣

I mean, I opted for the safer approach!

You both voted for the faster/ more dangerous one 😂 the tables seem to have turned since I was away

jdhoffa commented 6 months ago

See current status of migrating to new name: https://github.com/search?q=org%3ARMI-PACTA%20rmi-pacta%2Fpacta.pkgdown.template&type=code

Want to nip this in the bud before we forget. Based on the search above, we have:

Open PRs related to this:

Not relevant because archived: https://github.com/RMI-PACTA/pacta.portfolio.analysis https://github.com/RMI-PACTA/pacta.interactive.report

jdhoffa commented 6 months ago

Done! Closing this comment