search

RMI-PACTA / pacta.portfolio.allocate

https://rmi-pacta.github.io/pacta.portfolio.allocate/
Other
1 stars 0 forks source link

Update default delta_t2 value to be 9 #2

Closed jdhoffa closed 1 year ago

jdhoffa commented 1 year ago

Relates to: https://github.com/RMI-PACTA/workflow.data.preparation/pull/49

Related: @cjyetman would you be in favour of removing this determine_tdm_variables() function?

To me this is setting configuration values (like the value of delta_t1 and delta_t2 values), which I feel like would make more sense to isolate in workflow.transition.monitor.

Happy for the function to have sensible defaults, but I think we we are specifying the function configuration we should do it in a workflow.

cjyetman commented 1 year ago

Sure? Happy to take your lead on all things TDM... I don't fully understand how it all works.

jdhoffa commented 1 year ago

Sure? Happy to take your lead on all things TDM... I don't fully understand how it all works.

Ok I'm still not entirely sure exactly where to do it so just going to make an issue for now, but will consider doing this for the next release: https://github.com/RMI-PACTA/pacta.portfolio.allocate/issues/3

jdhoffa commented 1 year ago

Closing in favour of https://github.com/RMI-PACTA/workflow.transition.monitor/pull/179