Closed jdhoffa closed 6 months ago
Renames the argument twodi_sectors to pacta_sectors in a handful of places.
twodi_sectors
pacta_sectors
From the following search: https://github.com/search?q=org%3ARMI-PACTA%20twodi_sectors&type=code I've identified that this breaking change begets necessary changes in the following repos/ functions (the rest are archived):
[x] https://github.com/RMI-PACTA/pacta.interactive.plot/blob/d291638b7d2a2f724a006877ef968745e3b1adea/R/exposure_pie_chart.R#L51 Solved by: https://github.com/RMI-PACTA/pacta.interactive.plot/pull/44
[ ] https://github.com/RMI-PACTA/workflow.pacta.report/blob/864ee26bfac93e48fb354b93433187e677f86bc3/pacta_03.R#L248 Solved by: https://github.com/RMI-PACTA/workflow.pacta.report/pull/6
[ ] https://github.com/RMI-PACTA/workflow.transition.monitor/blob/91eb8b351bf924c278cc039d0ad4cbcb8bc24db2/web_tool_script_3.R#L223
[ ] https://github.com/RMI-PACTA/workflow.transition.monitor/blob/91eb8b351bf924c278cc039d0ad4cbcb8bc24db2/web_tool_script_3.R#L239 Both solved by: https://github.com/RMI-PACTA/workflow.transition.monitor/pull/294
Note this PR should be merged BEFORE all of the above PRs are merged. Just tracking it here so it's all in one place.
Closes #12
Renames the argument
twodi_sectors
topacta_sectors
in a handful of places.From the following search: https://github.com/search?q=org%3ARMI-PACTA%20twodi_sectors&type=code I've identified that this breaking change begets necessary changes in the following repos/ functions (the rest are archived):
[x] https://github.com/RMI-PACTA/pacta.interactive.plot/blob/d291638b7d2a2f724a006877ef968745e3b1adea/R/exposure_pie_chart.R#L51 Solved by: https://github.com/RMI-PACTA/pacta.interactive.plot/pull/44
[ ] https://github.com/RMI-PACTA/workflow.pacta.report/blob/864ee26bfac93e48fb354b93433187e677f86bc3/pacta_03.R#L248 Solved by: https://github.com/RMI-PACTA/workflow.pacta.report/pull/6
[ ] https://github.com/RMI-PACTA/workflow.transition.monitor/blob/91eb8b351bf924c278cc039d0ad4cbcb8bc24db2/web_tool_script_3.R#L223
[ ] https://github.com/RMI-PACTA/workflow.transition.monitor/blob/91eb8b351bf924c278cc039d0ad4cbcb8bc24db2/web_tool_script_3.R#L239 Both solved by: https://github.com/RMI-PACTA/workflow.transition.monitor/pull/294
Note this PR should be merged BEFORE all of the above PRs are merged. Just tracking it here so it's all in one place.
Closes #12