search

RMI-PACTA / pacta.portfolio.report

pacta.portfolio.report
https://rmi-pacta.github.io/pacta.portfolio.report/
MIT License
1 stars 0 forks source link

replace unnecessary jQuery with vanilla JavaScript #91

Open cjyetman opened 1 month ago

cjyetman commented 1 month ago

There are a sprinkling of jQuery specific commands that could easily be replaced with vanilla JavaScript, reducing/eliminating the dependency on jQuery, e.g.

https://github.com/search?q=repo%3ARMI-PACTA%2Fpacta.portfolio.report+%24.&type=code

For example, this... https://github.com/RMI-PACTA/pacta.portfolio.report/blob/f83c29e1988c87d428792a7e85251f4ebb5d7cac/inst/js/techexposure.js#L402-L404

could be replaced by...

legend_data.forEach((item) => { item["sector_shift"] = unique_sectors.indexOf(item.ald_sector_translation) });

as was done in https://github.com/RMI-PACTA/pacta.interactive.plot/pull/49