search

RMI-PACTA / pacta.scenario.data.preparation

The goal of {pacta.scenario.data.preparation} is to prepare and format all scenario input datasets required to run the {pacta.portfolio.allocate} tool.
https://rmi-pacta.github.io/pacta.scenario.data.preparation/
Other
1 stars 0 forks source link

Add steel cement aviation aps steps #61

Closed Antoine-Lalechere closed 2 months ago

Antoine-Lalechere commented 2 months ago

For Switzerland project, we are providing an aggregate score to any investors. The calculation of this indicator was previously made with GECO, but as we get some concerns with some GECO value in their last release, it will be provided against WEO2023 this year. To compute this indicator, we need to compute targets against three scenarios as the results we provide will be for example "Between APS and STEPS". We would then need to add Aviation, Steel and Cement targets based on APS and STEPS.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 16.75%. Comparing base (5c39255) to head (5510f19).

Files Patch % Lines
R/prepare_weo_2023_scenario.R 0.00% 30 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== - Coverage 16.83% 16.75% -0.09% ========================================== Files 13 13 Lines 2049 2059 +10 ========================================== Hits 345 345 - Misses 1704 1714 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cjyetman commented 2 months ago

@Antoine-Lalechere can we have a live discussion about this, ideally with @jacobvjk and @jdhoffa once he's back from vacation? On the surface, this appears to change code that has broad effect on things beyond just the Swiss COP, so I want to make sure we're not causing a detrimental effect elsewhere.

Antoine-Lalechere commented 2 months ago

@cjyetman I sent you @jacobvjk @jdhoffa an invitation for Thursday when Jackson is back, lmk if that time doesn't work for you