search

RMI-PACTA / pacta.scenario.data.preparation

The goal of {pacta.scenario.data.preparation} is to prepare and format all scenario input datasets required to run the {pacta.portfolio.allocate} tool.
https://rmi-pacta.github.io/pacta.scenario.data.preparation/
Other
1 stars 0 forks source link

bug: namespace `dplyr::case_when` #63

Closed jdhoffa closed 2 months ago

jdhoffa commented 2 months ago

The bug was introduced in https://github.com/RMI-PACTA/pacta.scenario.data.preparation/pull/61

Since we never load dplyr, namespacing is important. Not doing so resulted in the latest build of scenario prep not building weo_2023.

This slipped through our CI/CD because we currently set it to fail on WARNING rather than NOTE, and the lack of visible global binding only raises a NOTE.

FYI @Antoine-Lalechere @AlexAxthelm @cjyetman

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 16.75%. Comparing base (a4f3833) to head (ff0b306).

Files Patch % Lines
R/prepare_weo_2023_scenario.R 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #63 +/- ## ======================================= Coverage 16.75% 16.75% ======================================= Files 13 13 Lines 2059 2059 ======================================= Hits 345 345 Misses 1714 1714 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdhoffa commented 2 months ago

Scenario prep triggered here: https://github.com/RMI-PACTA/workflow.scenario.preparation/actions/runs/9723886605