RMI-PACTA / pactaCore

Tools to Calculate Climate Targets for Equity and Corporate Bond Portfolios
Other
0 stars 1 forks source link

New test fixutre local_pacta() #47

Closed maurolepore closed 3 years ago

maurolepore commented 3 years ago

This PR provides the new local_pacta() -- a test fixutre like many others in the withr package.

Also:

jdhoffa commented 3 years ago

I have comments about this (which I think are understood, but want to make it explicit for posterity):

With all of that said, #49 is the obvious reason to add all of this scaffolding, and having this snapshot test structure will allow us (hopefully) to quickly develop/ refactor and extract the core code back out of inst.

All of that to say, I back this, but with many caveats, and I think it is important we deal with it quickly.