search

RMI-PACTA / r2dii.data

Datasets to Align Financial Markets with Climate Goals
https://rmi-pacta.github.io/r2dii.data
Creative Commons Zero v1.0 Universal
6 stars 6 forks source link

feat: update `naics_classification` to latest version #355

Closed jdhoffa closed 7 months ago

jdhoffa commented 7 months ago

This PR updates the NAICS dataset to the latest version (published in "2022").

Relates to #344

@jacobvjk would appreciate a content review of this (especially on if some of these sectors should be Borderline). Steel in particular I was very unsure of.

jdhoffa commented 7 months ago

For posterity, the original raw data was pulled from here: https://www.census.gov/naics/?48967

jdhoffa commented 7 months ago

@jacobvjk updated the bridge to include all levels. This PR is ready for review now

jdhoffa commented 7 months ago

EDIT: nevermind think I sorted it out

After applying the suggested changes, I get this weird case where certain "not in scope" sectors are also classified as "borderline = TRUE".

Any suggestion what I should do there?

Screenshot 2024-03-19 at 15 39 15
jdhoffa commented 7 months ago

somehow my latest steel suggestions were lost in the process

ok this turned out very difficult to ensure i did correctly with half being "commit suggestions" and half just being "this is still open".

Tried to manually update it as you suggested but i may have made a mistake.

jacobvjk commented 7 months ago

somehow my latest steel suggestions were lost in the process

ok this turned out very difficult to ensure i did correctly with half being "commit suggestions" and half just being "this is still open".

Tried to manually update it as you suggested but i may have made a mistake.

I will give it another full review just to be sure