search

RMI-PACTA / r2dii.data

Datasets to Align Financial Markets with Climate Goals
https://rmi-pacta.github.io/r2dii.data
Creative Commons Zero v1.0 Universal
6 stars 6 forks source link

feat: update `sic_classification` to match the 1987 revision of the US SIC codes #357

Closed jdhoffa closed 7 months ago

jdhoffa commented 7 months ago

As documented here: https://www.osha.gov/data/sic-search

Note: it seems that the original sic_classification bridge was referencing the South African SIC standard, as documented here: https://www.statssa.gov.za/additional_services/sic/mdvdvmg4.htm#MAJOR%20DIVISIONS,DIVISIONS%20AND%20MAJOR%20GROUPS

We likely should assess if we want to continue to support that dataset (and probably need to name it something more specific to identify what it refers to).

Maybe closes #356

jdhoffa commented 7 months ago

Based on the decision here: https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/10292#30590656 We will update the sic_classification dataset to the US SIC codes for clarity.

If removing the SA SIC codes causes any issues, it is expected that the functionality soon to be introduced by https://github.com/RMI-PACTA/r2dii.match/issues/447 will handle this.

In particular, users will be able to flag that classification systems are missing.

@jacobvjk This is ready for review

Closes #356 and #344

jacobvjk commented 7 months ago

Given that we are using a 1987 revision here, I am wondering if SIC was largely superseded by other systems in the US and only the name persisted in other jurisdictions. Not for this PR, but definitely something to consider

jdhoffa commented 7 months ago

Given that we are using a 1987 revision here, I am wondering if SIC was largely superseded by other systems in the US and only the name persisted in other jurisdictions. Not for this PR, but definitely something to consider

Probably!