RMI-PACTA / r2dii.dataraw

Access raw or lightly prepared data
https://2degreesinvesting.github.io/r2dii.dataraw/
GNU General Public License v3.0
0 stars 3 forks source link

In `EQMarket.Size()`, likely we don't need factors at all #3

Closed maurolepore closed 5 years ago

maurolepore commented 5 years ago

In EQMarket.Size(), likely we don't need factors at all (https://github.com/2DegreesInvesting/Reference/issues/35#issuecomment-539384198).

@2diiKlaus, do you know of any reason for these two columns to remain as factors? Or can they be characters?

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
library(r2dii)
#> Loading required package: r2dii.dataraw
#> Loading required package: r2dii.utils

EQMarket.Size() %>% 
  select_if(is.factor)
#> # A tibble: 3 x 2
#>   IndexName             Market         
#>   <fct>                 <fct>          
#> 1 MSCI Emerging Markets EmergingMarket 
#> 2 MSCI World            DevelopedMarket
#> 3 MSCI ACWI             GlobalMarket

Created on 2019-10-08 by the reprex package (v0.3.0)

2diiKlaus commented 5 years ago

no there is no reason for them to stay factors