search

RMI-PACTA / r2dii.match

Tools to Match Financial Portfolios with Climate Data
https://rmi-pacta.github.io/r2dii.match
Other
7 stars 7 forks source link

Increment version number to 0.1.4.9000 #433

Closed jdhoffa closed 8 months ago

jdhoffa commented 8 months ago

Bump to dev version number.

jdhoffa commented 8 months ago

@AlexAxthelm all checks seem to be failing, is this a known problem? (follow-up, how did we get this onto CRAN with all the checks failing?)

AlexAxthelm commented 8 months ago

@jdhoffa the checks look to me like they might be using the wrong version of r2dii.data?

jdhoffa commented 8 months ago

@jdhoffa the checks look to me like they might be using the wrong version of r2dii.data?

Mauro wrote two different categories of tests. One test against the CRAN published version of r2dii.data (R-CMD-check), the other tests against the latest commit on main (R-CMD-check r2dii-devel)

All seem to fail.

jdhoffa commented 8 months ago

Yeah I also get 11 failed tests locally.

How did this make it to CRAN??? Are we sure it was accepted @AlexAxthelm

Screenshot 2024-01-10 at 12 22 30
jdhoffa commented 8 months ago

This PR is the culprit: https://github.com/RMI-PACTA/r2dii.match/commit/7a2b5921e933ec3dc4c3a2470ac20ee6cd51f37a

The call to skip_on_cran() there seems to skip about 87 tests.

Without skip() (179 total tests, 9 failing):

Screenshot 2024-01-10 at 12 34 07

with skip() (92 total tests, all passing):

Screenshot 2024-01-10 at 12 35 29

Those tests aren't skipped on CI and are why this PR is failing.

I will look into why all those tests are failing in a separate issue...

jdhoffa commented 8 months ago

Blocked by #434

jdhoffa commented 8 months ago

Actually, I'm going to force merge this, as whatever I do to fix these failing tests will need to be a "next release" kind of thing.