Closed jdhoffa closed 9 months ago
FYI, when I run devtools::test()
from main
on my machine, I get:
R4.3.2> devtools::test()
ℹ Testing r2dii.match
✔ | F W S OK | Context
✔ | 10 | add_sector_and_borderline
✔ | 7 | check_crucial_names
✔ | 1 | crucial_lbk
✔ | 5 | helper-fake_lbk
✔ | 84 | match_name [2.5s]
✔ | 27 | prioritize
✔ | 7 | restructure_abcd
✔ | 5 | select_chr
✔ | 25 | to_alias
✔ | 4 | uniquify_id_column
══ Results ═══════
Duration: 3.3 s
[ FAIL 0 | WARN 0 | SKIP 0 | PASS 175 ]
FYI, when I run
devtools::test()
frommain
on my machine, I get:R4.3.2> devtools::test() ℹ Testing r2dii.match ✔ | F W S OK | Context ✔ | 10 | add_sector_and_borderline ✔ | 7 | check_crucial_names ✔ | 1 | crucial_lbk ✔ | 5 | helper-fake_lbk ✔ | 84 | match_name [2.5s] ✔ | 27 | prioritize ✔ | 7 | restructure_abcd ✔ | 5 | select_chr ✔ | 25 | to_alias ✔ | 4 | uniquify_id_column ══ Results ═══════ Duration: 3.3 s [ FAIL 0 | WARN 0 | SKIP 0 | PASS 175 ]
That is running the CRAN installations of both r2dii.data
and r2dii.match
?
Hmm. it appears I was not. I'm also now. seeing failing tests.
This PR is the culprit: https://github.com/RMI-PACTA/r2dii.match/commit/7a2b5921e933ec3dc4c3a2470ac20ee6cd51f37a
The call to
skip_on_cran()
there seems to skip about 87 tests.Without
skip()
(179 total tests, 9 failing):with
skip()
(92 total tests, all passing):Those tests aren't skipped on CI and are why this PR is failing.
I will look into why all those tests are failing in a separate issue...
Originally posted by @jdhoffa in https://github.com/RMI-PACTA/r2dii.match/issues/433#issuecomment-1885409281