Fix failing tests due to updated `r2dii.data` data

RMI-PACTA / r2dii.match

Tools to Match Financial Portfolios with Climate Data

https://rmi-pacta.github.io/r2dii.match

Other

7 stars 5 forks source link

Fix failing tests due to updated `r2dii.data` data #435

Closed jdhoffa closed 9 months ago

jdhoffa commented 10 months ago

I did a handful of things to ensure the tests are passing as is, mainly to do with adapting tests to the updated format of loanbook_demo:

update snapshots
update expected col order
adapt test to new comp names
point to relevant entry

I also removed the call to skip_on_cran, as this should work fine now.

No update to NEWS.md required, as this is not user-facing.

Relates to #432 Closes #434

jdhoffa commented 10 months ago

FYI. @AlexAxthelm

jdhoffa commented 9 months ago

@jdhoffa any idea why a test is failing for some windows checks? the errors seem to point to an issue that we thought was closed: #425

Hmmm, I do not know why this test is failing... I would say this is not related directly to this PR (updating regressions from r2dii.data), and I would elect to open a new issue to handle this persistent Windows encoding issue.

jdhoffa commented 9 months ago

I have made a new issue in #436. I would suggest we merge this PR, and handle follow-up there.