search

RMI-PACTA / r2dii.plot

A package containing functions to create standard 2DII plots using ggplot, together with data processing functions needed for the charts.
https://rmi-pacta.github.io/r2dii.plot
Other
8 stars 1 forks source link

Revisit checks #516

Closed MonikaFu closed 9 months ago

MonikaFu commented 1 year ago

Right now there seem to be a lot of checks on different OSes which might be an overkill

jdhoffa commented 9 months ago

The checks used in r2dii.plot () are in line with what we checks we use for r2dii.analysis. Not saying that means we need to keep them, but it at least means their in-line with one another.

Note: there is a discussion going on in parallel around standardizing our checks across the PACTA tech team. Discussion is happening in the context of this repo: https://github.com/RMI-PACTA/demo_actions/issues

I would recommend closing this issue in favour of an issue/ discussion in that repo :-)

MonikaFu commented 9 months ago

@jdhoffa which issue exactly that is? I'm happy to move it there if it covers what I wanted to discuss here. Basically many times I had checks breaking for no reason and my intuition is that partly it is due to the fact that there are so many. Not sure if it is necessary to have so many checks for each PR. Maybe only for some when we make a release?

jdhoffa commented 9 months ago

Well it is not an issue, but the repository itself, where we plan to discuss what workflows to use for all repositories.

Eventually, we will try to base all of our repositories workflows off of this central place so that we don't have a bunch of different versions of the same thing

jdhoffa commented 9 months ago

I just made a new issue covering it here: https://github.com/RMI-PACTA/Actions/issues/12

jdhoffa commented 9 months ago

We will discuss it as well on February 1st I believe. I think @AlexAxthelm is going to send an invite.

MonikaFu commented 9 months ago

Closing this issue as the number and breadth of checks will be decided for all our repos when we solve this issue: https://github.com/RMI-PACTA/Actions/issues/12.