search

RMI-PACTA / r2dii.plot

A package containing functions to create standard 2DII plots using ggplot, together with data processing functions needed for the charts.
https://rmi-pacta.github.io/r2dii.plot
Other
8 stars 1 forks source link

Split `check_emission_intensity` into `check_prep_emission_intensity` and `check_plot_emission_intensity` #546

Closed jdhoffa closed 8 months ago

jdhoffa commented 8 months ago

Also requires adding additional checks to both functions, since it is expected that their inputs should differ dramatically (so likely the checks should too)

          I agree in principle that the `checks` likely should be different as they test different input. However in practice, the were checking the presence of the exact same columns.

That to me suggests that check_plot_emission_intensity and check_prep_emission_intensity likely should be expanded to include more precise checking, but I think that is out of scope for this PR.

I will open a new issue to that effect.

_Originally posted by @jdhoffa in https://github.com/RMI-PACTA/r2dii.plot/pull/543#discussion_r1488101565_