style: Consider using a `config.yml` to set default parameters - Githubissues

RMI-PACTA / workflow.aggregate.loanbooks

This repository produces analyses used to compare the loan books across many banks, including bulk PACTA runs and aggregation metrics including plots.

MIT License

0 stars 0 forks source link

style: Consider using a `config.yml` to set default parameters #69

Open jdhoffa opened 6 months ago

jdhoffa commented 6 months ago

I have used a .env in the past, however I realized this is mainly only because it plays nicely with Docker and is especially useful when volume-mounting local directories into a container/ image.

For some of the default parameters it MAY make more sense to use a config.yml, as is done in workflow.data.preparation and friends: https://github.com/RMI-PACTA/workflow.aggregate.loanbooks/blob/207a5140e49cd913fe6b05c4dc1ba2180dc29c85/README.md?plain=1#L45-L61

https://github.com/RMI-PACTA/workflow.data.preparation/blob/main/config.yml

jacobvjk commented 4 months ago

this will be handled by the refactor and move to workflow.multi.loanbook