migrate `override_sector_by_factset_entity_id()` to this repo

RMI-PACTA / workflow.factset

Other

0 stars 0 forks source link

migrate `override_sector_by_factset_entity_id()` to this repo #34

Closed AlexAxthelm closed 4 months ago

AlexAxthelm commented 5 months ago

https://github.com/RMI-PACTA/pacta.data.preparation/blob/68584328e9d06f3fcf03f8c200f41361836a454c/R/override_sector_by_factset_entity_id.R#L4

relates to #29

AlexAxthelm commented 4 months ago

Closing since this function should not be migrated, as it lives in data prep. necessary changes are covered in #35

cc @cjyetman

cjyetman commented 4 months ago

thanks, makes sense. The factset_manual_pacta_sector_override file will live (eventually) in workflow.factset (or at least in its outputs) #35, but the function override_sector_by_factset_entity_id() will stay in pacta.data.preparation (because it doesn't contain any private data, just the logic to process its two inputs)