search

RMI-PACTA / workflow.factset

Other
0 stars 0 forks source link

Feat/33 migrate issue code bridge #39

Closed AlexAxthelm closed 4 months ago

AlexAxthelm commented 4 months ago

This migrates the current state of pacta.data.preparation's factset_issue_code_bridge.R (in data-raw).

Of note as a functional change, adding the PACTA asset_type was previously a manual step (see comment in that file). This PR takes the current state of that mapping, and implements it as code.

Closes #33

github-actions[bot] commented 4 months ago

Docker image from this PR (5dda148f6fda7afc2416e877574e0e4a8dc46f56) created

docker pull ghcr.io/rmi-pacta/workflow.factset:pr39
AlexAxthelm commented 4 months ago
  • small warning that in the past, analysts have needed to modify this matching by hand, which may be a maintenance burden (it was easier to get them to edit a CSV)

Given the methodological implications of this mapping, adding a maintenance burden to changing this seems like a good thing.

  • small warning that occasionally I've been asked (even once in the past couple weeks) to verify/validate/prove what this mapping currently looks like, to which I often gave a link to the CSV in the repository which seemed easiest for analysts to review (maybe the RDS output of this will be sufficient in the future)

Seems reasonable that we should export a CSV in addition to / instead of the RDS. Preference?

AlexAxthelm commented 4 months ago
  • can't test

I'll get you a generated file out of band. (check Teams)