search

RMI-PACTA / workflow.factset

Other
0 stars 0 forks source link

Release v1.0.0 #48

Closed AlexAxthelm closed 7 months ago

AlexAxthelm commented 7 months ago

🎉 Let's call this 1.0.0, since I believe this is feature complete

Update docs, and version bump

github-actions[bot] commented 7 months ago

Docker image from this PR (4815eecee294ebc1b1349d7ffcc6df76bc0340e3) created

docker pull ghcr.io/rmi-pacta/workflow.factset:pr48
jdhoffa commented 7 months ago

I think before I approve a 1.0.0 version bump (keeping in mind that I have no idea how we are managing versions right now), I would like to have a call to prove to myself that I can run the API

Can you block time to go over that?

In general, this feels like something we should coordinate in a tech review or something like that?

Also can you please make the PR title a bit more descriptive? "Chore" doesn't seem indicative of the fact that this is a "first major release" (noting that many r2dii packages still aren't at version 1)...

jdhoffa commented 7 months ago

Or not, do as you like haha

AlexAxthelm commented 7 months ago

@jdhoffa Merging, while noting your concerns about running. I'm labelling the R package here as 1.0.0, while the deploy script (which is a living document that reflects our current infrastructure) is not included in that classification.

I don't know of a good way to make that distinction clear off the top of my head.