search

RMI-PACTA / workflow.factset

Other
0 stars 0 forks source link

Deploy/50 update deploy scripts #52

Closed AlexAxthelm closed 4 months ago

AlexAxthelm commented 4 months ago

This PR updates t he deploy script and documentation, to account for changes in RMI's Azure infrastructure.

Of particular note is the azure-deploy.rmi-pacta.parameters.json file, which, if called as part of the az deployment create command (See updated README), will allow members of the RMI Active Directory with correct permissions (@cjyetman, @jdhoffa, and @AlexAxthelm ) to deploy a container instance which handle connecting to our Azure File Shares and deploying and authenticating to a Postgres database correctly, leavingdata_timestamp and iss_reporting_year as the important parameters to be entered manually.

AlexAxthelm commented 4 months ago

Suggested Review steps:

Execute the command in the "Deploy" Section of readme and see that the process proceeeds correctly (runs remotely, but takes ~12 hours)

github-actions[bot] commented 4 months ago

Docker image from this PR (71d79040278a9f3689bb429985d0944528ee2c75) created

docker pull ghcr.io/rmi-pacta/workflow.factset:pr52
jdhoffa commented 4 months ago

When running the instructions for "Users with an RMI-PACTA Azure subscription", I get prompted for the following value:

Screenshot 2024-02-16 at 18 05 09

It's not clear to me what to set this to?

AlexAxthelm commented 4 months ago

@jdhoffa updated docs. That parameter doesn't affect behavior, but is a label so you can manage the resources (container group & db), such as deleting them later, or finding them in the Azure Portal.

jdhoffa commented 4 months ago

Hey, so I get an error regarding the "refresh token"? I don't have enough context to really know what this means:

Screenshot 2024-02-20 at 17 07 40
AlexAxthelm commented 4 months ago

Hey, so I get an error regarding the "refresh token"?

That one's new to me, but it looks like an error from az. I'm guessing here, but it looks like you took too long entering the parameters?

Try again with those same responses, but take less than 90 seconds this time?

jdhoffa commented 4 months ago

I don't think that's it, I blazed through parameter setting that run to no avail:

Screenshot 2024-02-21 at 09 20 49

Note: it says the token was issued last year in August? Which is broadly in-line with the last time I was working with Azure? I wonder if I need to reset something on my account end?

AlexAxthelm commented 4 months ago

Oh, then you probably need to refresh your credentials. az login (no flags, since you're trying to use your Azure Active Directory identity, not a system assigned one, which is why for our container running VMs, we use az login --identity, such as here)

jdhoffa commented 4 months ago

Thank you! Seems to be running now. FYI. if you see a containerGroup on Azure called "jackson-test" that would be me :-)